Lvgl v8.0 #734

Quantum-cross · 2021-10-08T21:34:53Z

Here's my first pass at upgrading pinetime to lvgl 8.

Still to do:

Port pinetime theme (I just copied the default lvgl theme for now)
Test on an actual PineTIme
Go through with fine tooth comb fixing layout/padding/alignment differences
Cleaning event handlers (using event filters) (this could be deferred to another PR)
fix Twos (very important)
change pad_row+pad_col -> pad_gap
implemented custom lvgl screen transitions
improve screen transition performance

This is a WIP, I'm creating it as a draft. I'll keep yall updated here, but early feedback and testing is appreciated.

Ported theme!

Many fixes:

More fixes!!!

Resolves #616

It builds and I have gotten output using my hacks to dev on my nrf52833-DK, but it quickly crashes with memory issues. I have traced freeRTOS stack overflows on tasks with previous `usStackDepth` values: - "MAIN" - "displayapp" - "Heartrate" I've tried tweaking the stack/heap values but have always experienced memory corruption errors. I'm currently waiting for my pinetime devkit to arrive :) I've also enabled `configCHECK_FOR_STACK_OVERFLOW` and put a basic implementation of `vApplicationStackOverflowHook` in `rtoshook.c`. You need to set a breakpoint to read the task name unless you put in a log statement.

…kept in an lv_indev object in the lv_indev_ll. Store it as a member variable to keep it alive.

…API.

# Conflicts: # src/displayapp/screens/Alarm.h # src/displayapp/screens/SystemInfo.cpp

NeroBurner · 2021-10-11T20:54:59Z

can't compile your branch locally getting error

[build] /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp: In member function 'void Pinetime::System::SystemTask::Work()':
[build] /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp:159:29: error: no matching function for call to 'Pinetime::Applications::DisplayApp::Start(Pinetime::System::BootErrors&)'
[build]   159 |   displayApp.Start(bootError);
[build]       |                             ^
[build] In file included from /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.h:25,
[build]                  from /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp:1:
[build] /home/nero/repos/pinetime/InfiniTime/src/displayapp/DisplayAppRecovery.h:60:12: note: candidate: 'void Pinetime::Applications::DisplayApp::Start()'
[build]    60 |       void Start();
[build]       |            ^~~~~
[build] /home/nero/repos/pinetime/InfiniTime/src/displayapp/DisplayAppRecovery.h:60:12: note:   candidate expects 0 arguments, 1 provided
[build] make[2]: *** [src/CMakeFiles/pinetime-mcuboot-recovery.dir/build.make:664: src/CMakeFiles/pinetime-mcuboot-recovery.dir/systemtask/SystemTask.cpp.o] Error 1

do I maybe need to update a dependency (other than the lvgl submodule)?

- used basic objects instead of table - only updates squares that are changed - add indicator that shows which square is new

Quantum-cross · 2021-10-11T21:13:18Z

can't compile your branch locally getting error

[build] /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp: In member function 'void Pinetime::System::SystemTask::Work()':
[build] /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp:159:29: error: no matching function for call to 'Pinetime::Applications::DisplayApp::Start(Pinetime::System::BootErrors&)'
[build]   159 |   displayApp.Start(bootError);
[build]       |                             ^
[build] In file included from /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.h:25,
[build]                  from /home/nero/repos/pinetime/InfiniTime/src/systemtask/SystemTask.cpp:1:
[build] /home/nero/repos/pinetime/InfiniTime/src/displayapp/DisplayAppRecovery.h:60:12: note: candidate: 'void Pinetime::Applications::DisplayApp::Start()'
[build]    60 |       void Start();
[build]       |            ^~~~~
[build] /home/nero/repos/pinetime/InfiniTime/src/displayapp/DisplayAppRecovery.h:60:12: note:   candidate expects 0 arguments, 1 provided
[build] make[2]: *** [src/CMakeFiles/pinetime-mcuboot-recovery.dir/build.make:664: src/CMakeFiles/pinetime-mcuboot-recovery.dir/systemtask/SystemTask.cpp.o] Error 1

do I maybe need to update a dependency (other than the lvgl submodule)?

Fixed that, I never tried building the recovery image.

Improve timer to not refresh screen constantly while running.

A bit more graceful and doesn't mess with any task schedulers.

Use flexbox for Quicksettings

fix arc theming fix notification scroll animation improved redundant drawing in steps, stopwatch

geekbozu · 2021-10-13T14:00:45Z

I will enabled Checks for this so it will build DFUs for testing as I see you make pushes. Good luck with this its on my to review list!

geekbozu

Is this an error with JUST lvgl8 or in the mainstream repo? If its in the mainstream maybe you should consider a backport/seperate PR for it.

Move all transition animations to the new logic

Quantum-cross · 2021-10-14T11:18:35Z

My pinetime DK is arriving tomorrow so I can finally start testing on the actual hardware soon.

Removed the notification to protect the data/cmd lcd pin, instead stuffed that logic inside the mutex of the Spi driver... This probably isn't the BEST way to do it, but it's working great for now.

Quantum-cross · 2021-10-14T22:05:18Z

screen blanking errors should be fixed on real hardware!

The ST7789 driver is a bit of a mess right now. I'd like to refactor it some time.

Quantum-cross · 2021-10-15T00:58:12Z

This might be ready for a daily driver test.

I'm going to work on cleaning up the event handlers over the weekend but those changes shouldn't change any function.

Fix theming for basic labels. Add short url for github address.

JF002 · 2021-10-16T12:16:07Z

@Quantum-cross Thanks for your work on this PR! It looks like the port to LVGL8 is not as straightforward as for previous versions!

Have you already had the opportunity to check the memory usage (RAM and FLASH) since you've integrated LVGL8? We are already tight on memory, and I wouldn't want this updater to use too much of the remaining memory.

NeroBurner · 2021-10-16T17:37:09Z

@Quantum-cross got a build error again

[build] Memory region         Used Size  Region Size  %age Used
[build]            FLASH:      391208 B       480 KB     79.59%
[build]              RAM:       53368 B        64 KB     81.43%
[build] /home/nero/repos/pinetime/gcc-arm-none-eabi-9-2020-q2-update/bin/../lib/gcc/arm-none-eabi/9.3.1/../../../../arm-none-eabi/bin/ld: CMakeFiles/pinetime-mcuboot-app.dir/drivers/SpiNorFlash.cpp.o: in function `Pinetime::Drivers::SpiNorFlash::Sleep()':
[build] /home/nero/repos/pinetime/InfiniTime/src/drivers/SpiNorFlash.cpp:23: undefined reference to `Pinetime::Drivers::Spi::Write(unsigned char const*, unsigned int)'
[build] collect2: error: ld returned 1 exit status
[build] make[2]: *** [src/CMakeFiles/pinetime-mcuboot-app.dir/build.make:1781: src/pinetime-mcuboot-app-1.6.0.out] Error 1

broke with commit ce23767

NeroBurner · 2021-10-16T17:46:12Z

@JF002 I don't know if that is what you're asking for, but the build output for ce63f51 shows the following memory usages

[build] [ 61%] Linking CXX executable pinetime-mcuboot-recovery-loader-1.6.0.out
[build] Memory region         Used Size  Region Size  %age Used
[build]            FLASH:      165172 B       480 KB     33.60%
[build]              RAM:       19116 B        64 KB     29.17%
[build] Memory region         Used Size  Region Size  %age Used
[build]            FLASH:      391064 B       480 KB     79.56%
[build]              RAM:       53368 B        64 KB     81.43%
[build] post build steps for pinetime-mcuboot-recovery-loader-1.6.0
[build] post build steps for pinetime-app-1.6.0
[build]    text	   data	    bss	    dec	    hex	filename
[build]  165172	    120	  18996	 184288	  2cfe0	pinetime-mcuboot-recovery-loader-1.6.0.out
[build]    text	   data	    bss	    dec	    hex	filename
[build]  391064	    592	  52772	 444428	  6c80c	pinetime-app-1.6.0.out
[build] [ 78%] Built target pinetime-app
[build] Memory region         Used Size  Region Size  %age Used
[build]            FLASH:      391064 B       480 KB     79.56%
[build]              RAM:       53368 B        64 KB     81.43%
[build] post build steps for pinetime-mcuboot-app-1.6.0
[build]    text	   data	    bss	    dec	    hex	filename
[build]  391064	    592	  52772	 444428	  6c80c	pinetime-mcuboot-app-1.6.0.out
[build] [ 79%] Linking CXX executable pinetime-recovery-loader-1.6.0.out
[build] [ 81%] Built target pinetime-mcuboot-recovery-loader
[build] [ 98%] Built target pinetime-mcuboot-app
[build] Memory region         Used Size  Region Size  %age Used
[build]            FLASH:      165172 B       480 KB     33.60%
[build]              RAM:       19116 B        64 KB     29.17%
[build] post build steps for pinetime-recovery-loader-1.6.0
[build]    text	   data	    bss	    dec	    hex	filename
[build]  165172	    120	  18996	 184288	  2cfe0	pinetime-recovery-loader-1.6.0.out
[build] [100%] Built target pinetime-recovery-loader

NeroBurner · 2021-10-16T21:35:04Z

@Quantum-cross you might want to cherry-pick b13aec2 to fix the Game "Twos". On my simulator the initialization of the cell-objects ran out of memory, resulting in a segmentation fault. So I reverted to use lv_table

Quantum-cross · 2021-10-17T16:04:47Z

@Quantum-cross you might want to cherry-pick b13aec2 to fix the Game "Twos". On my simulator the initialization of the cell-objects ran out of memory, resulting in a segmentation fault. So I reverted to use lv_table

I'm going to worry about performance optimization first right now, I'm messing with the ST driver and such.

If I can't increase the speed of scrolling then I think lvgl8 is dead in the water.

If I can fix the speed issues then I'll look into memory.

I'm mostly just testing the pinetime-app cmake target right now.

kieranc · 2021-10-21T18:22:20Z

I finally got round to testing this - I'm impressed with how much works! Yes the scrolling is a bit slow and the colors look washed out somehow? But it's huge progress!

lman0 · 2021-10-23T12:12:43Z

If I can't increase the speed of scrolling then I think lvgl8 is dead in the water.

If I can fix the speed issues then I'll look into memory.

i think you should look in the memory first and it may allow more speed improvement
because , when my pc have very little memory free it become very slow
so i think it's the same for an os like infintime @Quantum-cross

Quantum-cross · 2021-10-23T15:01:10Z

I finally got round to testing this - I'm impressed with how much works! Yes the scrolling is a bit slow and the colors look washed out somehow? But it's huge progress!

Good to hear!!! Still working on the scrolling, colors may be washed out because I may not have copied the themes exactly. I'll have to go through and double check that later.

Thanks for testing!

If I can't increase the speed of scrolling then I think lvgl8 is dead in the water.
If I can fix the speed issues then I'll look into memory.

i think you should look in the memory first and it may allow more speed improvement because , when my pc have very little memory free it become very slow so i think it's the same for an os like infintime @Quantum-cross

Sure, also there was talk about maybe combining the heaps of FreeRTOS and lvgl.

Overall I have not had much time to work on this the past week. It's still near the top of my list though!

kieranc · 2021-10-23T16:26:25Z

I think this is a PR which is going to need extensive testing so there's no rush, and initial progress looks very promising. I did just run a DFU to the LVGL8 build though, and the DFU screen is very broken! It completed just fine, but if you want something easier to tackle than scrolling speed, there's that :-)
I guess you've tried lv_page_set_anim_time ? Apparently the default is 400ms which is fairly slow.

Riksu9000 · 2022-07-29T17:02:33Z

@Quantum-cross Do you think there's any hope in updating this or is it easier to start over? As you've put a lot of effort into this and are more familiar with the changes required, do you know if there are things we could do in preparation for upgrading to make the process easier, like making some preliminary changes for example?

pipe01 · 2023-10-14T22:21:17Z

Any updates on this?

NeroBurner · 2023-10-28T20:10:06Z

While creating InfiniSim I've based my development on this lvgl8 port. I think I got to a working state, but the memory consumption of lvgl8 was higher than lvgl7. Crashing the PineTimeStyle watch face with then new settings menu. Maybe that was a bug in lvgl8 and it is fixed now, but I don't know, as I've not tested it since then

Anyways my work sprinkled with simulator based commits can be found here: https://github.com/NeroBurner/InfiniTime/commits/lv_simulation_lvgl8

maybe someone finds it useful

darkdragon-001 · 2024-12-26T18:23:13Z

Any chance the remaining bugs are fixed now and the upgrade is unblocked?

Quantum-cross added 20 commits October 8, 2021 08:40

Update submodule to lvgl v8.0

7622964

This variable goes out of scope after the init, but its reference is …

df7a417

…kept in an lv_indev object in the lv_indev_ll. Store it as a member variable to keep it alive.

Merge branch 'indev_drv_scope_fix' into nrf52833-DK

c679ab3

Found the same issue with fs_drv.

12d985a

Merge branch 'indev_drv_scope_fix' into nrf52833-DK

ee58e82

Fixes for List and Tile screen event handlers

15bd632

Merge branch 'lvgl-v8.0' into nrf52833-DK

5c01d12

Port pinetime theme

23d8b2c

Merge branch 'lvgl-v8.0' into nrf52833-DK

36311c5

Implementation of LeftAnim, RightAnim, ScrollDown using public lvgl8 …

16910e6

…API.

Merge branch 'lvgl-v8.0' into nrf52833-DK

382671f

stop digital watch face from constantly refreshing

fb632d4

center icons on quicksettings

edc88e9

Merge branch 'indev_drv_scope_fix' into lvgl-v8.0

640395e

Fix many alignment issues

33a6be5

Merge remote-tracking branch 'fork/lvgl-v8.0' into lvgl-v8.0

c686d9e

Fix small glitch with the first frame of scrolldown animation.

f99b15f

Merge branch 'develop' into lvgl-v8.0

26e6c52

# Conflicts: # src/displayapp/screens/Alarm.h # src/displayapp/screens/SystemInfo.cpp

Port latest PRs

4602efc

Quantum-cross added 2 commits October 11, 2021 16:55

VERY IMPORTANT! fix twos for lvgl8

4a8049a

- used basic objects instead of table - only updates squares that are changed - add indicator that shows which square is new

fix building of Recovery image.

7c7cae9

Quantum-cross added 6 commits October 11, 2021 18:03

Possible fix for reset on animation on actual pinetime

289df3f

clean pad_row/column to pad_gap

a6dbb1b

More alignment fixes

c6b59fa

Improve timer to not refresh screen constantly while running.

Next attempt at fixing screen transitions.

22e3d88

A bit more graceful and doesn't mess with any task schedulers.

add screen transitions for SystemInfo.

60a7229

Fix alignments for QuickSettings and Settings (List).

1c06449

Use flexbox for Quicksettings

Quantum-cross added 2 commits October 12, 2021 21:22

Fix most other alignment issues

9ab44a3

fix arc theming fix notification scroll animation improved redundant drawing in steps, stopwatch

Port PTS fixes to SettingPTS

dd9ba77

geekbozu reviewed Oct 13, 2021

View reviewed changes

Another attempt fixing animation issues

ce63f51

Move all transition animations to the new logic

Avamander mentioned this pull request Oct 13, 2021

Refactor shared watch face code into base class #451

Closed

Quantum-cross mentioned this pull request Oct 13, 2021

Recovery doesn't build because DisplayAppRecovery::Start() doesn't take new BootError #742

Closed

NeroBurner mentioned this pull request Oct 13, 2021

Lvgl simulation run PineTime screens on your PC #743

Merged

Fix screen animation errors (testing with actual ST7789)

ce23767

Removed the notification to protect the data/cmd lcd pin, instead stuffed that logic inside the mutex of the Spi driver... This probably isn't the BEST way to do it, but it's working great for now.

Improve lvgl8 performance for system info screen.

24c72b7

Fix theming for basic labels. Add short url for github address.

Riksu9000 mentioned this pull request Oct 30, 2021

Theme and color cleanup #667

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lvgl v8.0 #734

Lvgl v8.0 #734

Quantum-cross commented Oct 8, 2021 •

edited

Loading

NeroBurner commented Oct 11, 2021

Quantum-cross commented Oct 11, 2021

geekbozu commented Oct 13, 2021 •

edited

Loading

geekbozu left a comment •

edited

Loading

Quantum-cross commented Oct 14, 2021

Quantum-cross commented Oct 14, 2021 •

edited

Loading

Quantum-cross commented Oct 15, 2021

JF002 commented Oct 16, 2021

NeroBurner commented Oct 16, 2021 •

edited

Loading

NeroBurner commented Oct 16, 2021

NeroBurner commented Oct 16, 2021

Quantum-cross commented Oct 17, 2021

kieranc commented Oct 21, 2021

lman0 commented Oct 23, 2021

Quantum-cross commented Oct 23, 2021

kieranc commented Oct 23, 2021

Riksu9000 commented Jul 29, 2022

pipe01 commented Oct 14, 2023

NeroBurner commented Oct 28, 2023

darkdragon-001 commented Dec 26, 2024

Lvgl v8.0 #734

Are you sure you want to change the base?

Lvgl v8.0 #734

Conversation

Quantum-cross commented Oct 8, 2021 • edited Loading

Ported theme!

Many fixes:

More fixes!!!

NeroBurner commented Oct 11, 2021

Quantum-cross commented Oct 11, 2021

geekbozu commented Oct 13, 2021 • edited Loading

geekbozu left a comment • edited Loading

Choose a reason for hiding this comment

Quantum-cross commented Oct 14, 2021

Quantum-cross commented Oct 14, 2021 • edited Loading

Quantum-cross commented Oct 15, 2021

JF002 commented Oct 16, 2021

NeroBurner commented Oct 16, 2021 • edited Loading

NeroBurner commented Oct 16, 2021

NeroBurner commented Oct 16, 2021

Quantum-cross commented Oct 17, 2021

kieranc commented Oct 21, 2021

lman0 commented Oct 23, 2021

Quantum-cross commented Oct 23, 2021

kieranc commented Oct 23, 2021

Riksu9000 commented Jul 29, 2022

pipe01 commented Oct 14, 2023

NeroBurner commented Oct 28, 2023

darkdragon-001 commented Dec 26, 2024

Quantum-cross commented Oct 8, 2021 •

edited

Loading

geekbozu commented Oct 13, 2021 •

edited

Loading

geekbozu left a comment •

edited

Loading

Quantum-cross commented Oct 14, 2021 •

edited

Loading

NeroBurner commented Oct 16, 2021 •

edited

Loading