Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused DisplayApp messages #2104

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

mark9064
Copy link
Member

There are some old left over messages from before RestoreBrightness became NotifyDeviceActivity, and also some other ones that are well before my time. Since screens pull the time directly from the time controller, removing UpdateDateTime seems justified. And I can't think of anything that'd want to send DimScreen to DisplayApp, so I removed this too (the message is currently unused)

Copy link

github-actions bot commented Aug 23, 2024

Build size and comparison to main:

Section Size Difference
text 378772B -128B
data 948B 0B
bss 63488B 0B

@mark9064 mark9064 force-pushed the displayapp-cleanup branch from 60c6623 to 2506db2 Compare August 23, 2024 23:50
@mark9064
Copy link
Member Author

Simplified RestoreBrightness() away too

@JF002 JF002 added this to the 1.15.0 milestone Sep 14, 2024
@JF002 JF002 merged commit 5040733 into InfiniTimeOrg:main Sep 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants