Update logic of numberIndicator and stories

Infineon · Jan 17, 2025 · 0b22755 · 0b22755
1 parent 9db9f18
commit 0b22755
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/components/src/components/navigation/sidebar/sidebar-item.tsx b/packages/components/src/components/navigation/sidebar/sidebar-item.tsx
@@ -303,15 +303,15 @@ export class SidebarItem {
             <slot />
           </div>
           {
-          (this.isExpandable || (this.numberIndicator !== null && this.numberIndicator !== 0)) &&
+          (this.isExpandable || (this.numberIndicator !== undefined && this.numberIndicator !== null && !isNaN(this.numberIndicator))) &&
             <div class="sidebar__nav-item-indicator">
               {this.isExpandable &&
                 <span class='item__arrow-wrapper'>
                   <ifx-icon icon="chevron-down-12" />
                 </span>
               }
 
-              {this.numberIndicator != null && !this.isExpandable && !this.isNested &&
+              {this.numberIndicator != undefined && this.numberIndicator !== null && !isNaN(this.numberIndicator) && !this.isExpandable && !this.isNested &&
                 <span class='item__number-indicator'>
                   <ifx-number-indicator>{this.numberIndicator}</ifx-number-indicator>
                 </span>}

diff --git a/packages/components/src/components/navigation/sidebar/sidebar.stories.ts b/packages/components/src/components/navigation/sidebar/sidebar.stories.ts
@@ -133,9 +133,9 @@ export const WithSubmenu = SubmenuTemplate.bind({});
 
 const NumberIndicatorTemplate = () =>
   `<ifx-sidebar application-name="Application name">
-  <ifx-sidebar-item icon="image-16" number-indicator="5">Menu Item</ifx-sidebar-item>
-  <ifx-sidebar-item icon="image-16" number-indicator="1">Menu Item</ifx-sidebar-item>
-  <ifx-sidebar-item icon="image-16" number-indicator="23">Menu Item</ifx-sidebar-item>
+  <ifx-sidebar-item icon="image-16" number-indicator=5>Menu Item</ifx-sidebar-item>
+  <ifx-sidebar-item icon="image-16" number-indicator=1>Menu Item</ifx-sidebar-item>
+  <ifx-sidebar-item icon="image-16" number-indicator=23>Menu Item</ifx-sidebar-item>
   <ifx-sidebar-item active="false">
     Header Section
     <ifx-sidebar-item icon="image-16" active="false" >