Attribute id contains dataset #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagmarcel
force-pushed
the
attribute-id-contains-datasetId
branch
2 times, most recently
from
7ca2657 to
f223d29
Compare
Id of an attribute was so far created cannonically, i.e. id\\name This turns out to be misleading and wasting bandwidth. Therefore, the SHA256 hashing algorithm which was applied previously is now also applied to the highest level attributes. This has to be done aligned between MQTT Bridge and Debezium Bridge Signed-off-by: marcel <[email protected]>
Alerta normally consumes all records from Kafka. In case of error it will sleep some time and try it again. However, there are unrecoverable errors, e.g. when the severity code is wrong then Alerta is stuck for some time (as long as Kafka is storing the record). Therefore a function is added which detects and drops errors which are not recoverable. Signed-off-by: marcel <[email protected]>
DiffAttriutes was using attributeName + datasetId to uniquely identify an attribute
This is breaking when subattributes are introduced since attributename + datasetId can be
the same in subattributes such as in:
{
"id": "id",
"type": "type,
"attributes": {
"type": "Property",
"value": "value"
"attribute": {
"type": "Property",
"value": "value2"
}
}
}
Both attributes have name "attribute" and default datasetId '@none'.
Since a recent patch assigned every attribute a "local" unique id in the local database
a better way is to use this loaclly unique id to reference the attributes from now.
Signed-off-by: marcel <[email protected]>
wagmarcel
force-pushed
the
attribute-id-contains-datasetId
branch
from
7fe8623 to
5854036
Compare
abhijith-hr
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.