Migrate NGSI-LD Agent to DigitalTwin #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagmarcel
force-pushed
the
ngsild-agent-with-tests+timescale-update
branch
from
cdd86a5 to
ce40ed4
Compare
wagmarcel
changed the title
wagmarcel
requested review from
abhijith-hr
and removed request for
abhijith-hr
This PR provides a cleaned-up and simplified device agent. The device agent is responsible to connect to MQTT, manage the device token and forwards metrics provided over local udp/tcp protocol. The orginial oisp device admin has been removed and replaced by scripts to manage device onboarding and do test data sending. The original oisp-agent had many ways to communicate to the backend. This has been removed. Now, only the SparkplugB oriented data sending for NGSI-LD data is supported. The agent relies only on two services: (1) Keycloak and (2) MQTT. Since the onboarding only relies on Keycloak, there is a little change on activation procedure. Details are described in the README. Related Epic: IndustryFusion#432 Related User Story: IndustryFusion#446 Related Tasks: IndustryFusion#400, IndustryFusion#445, IndustryFusion#447 Signed-off-by: marcel <[email protected]> fix of copyright years Signed-off-by: marcel <[email protected]>
The insert strategy led to a situation that when a metric had same attribute and timestamp, the most recent insertion is ignored. With Upsert it is the other way round: older metrics are overwritten. Therefore the upsert strategy is chosen as policy. Related Epic: IndustryFusion#432 Signed-off-by: marcel <[email protected]>
wagmarcel
force-pushed
the
ngsild-agent-with-tests+timescale-update
branch
from
ce40ed4 to
6a95c73
Compare
abhijith-hr
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.