Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for specifying routing keys #10

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Aug 9, 2022

This PR enables the echo agent to communicate with agents behind mediators by adding support for specifying routing keys.

This PR includes a BREAKING CHANGE. their_vk has been removed.

This PR also changes the base of the docker image to debian. Alpine had a weird bug where the kernel would crash in the middle of installing python dependencies of the project, recover, then finish the build. It worked but caused a significant delay in builds.

dbluhm added 3 commits August 8, 2022 17:42
to resolve slow build times on alpine

Signed-off-by: Daniel Bluhm <[email protected]>
BREAKING CHANGE: their_vk removed

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm dbluhm requested a review from mepeltier August 9, 2022 02:07
Copy link
Contributor

@mepeltier mepeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@dbluhm dbluhm merged commit ac45b8b into main Aug 9, 2022
@dbluhm dbluhm deleted the feature/routing-keys branch August 9, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants