Base record replace webhooks with events #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Wright <[email protected]>
dbluhm
approved these changes
Apr 5, 2021
| """ | ||
| if not payload: | ||
|
|
||
| if not self.RECORD_TOPIC or not self.state or not payload: |
There was a problem hiding this comment.
Calling out the logic I'm seeing to validate intent: so if the BaseRecord subclass does not define a RECORD_TOPIC or the state has not been correctly set on the record, or if no payload is given, no event will be emitted. Looking at the diff, this is what was happening before as well, just simplified.
There was a problem hiding this comment.
Yes, same intent as before, we don't want to send events if there is not topic+state+payload. Before, there was no state and you could pass in a webhook topic to override.
aries_cloudagent/admin/server.py
Outdated
Comment on lines
712
to
716
|
|
||
| if not webhook_topic: | ||
| match = EVENT_PATTERN_RECORD.search(event.topic) | ||
| webhook_topic = match.group(1) if match else None | ||
|
|
There was a problem hiding this comment.
Would it perhaps simplify the event handling here to separate this into two subscribers, one for the webhook pattern and one for the record pattern?
Signed-off-by: Matthew Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all webhook stuff from BaseRecord so it now just uses events.
I namespaced the events like this:
acapy::record::{RECORD_TOPIC}::{state}This way we can easily catch all the record events and forward them to webhooks.