-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle macos SDK in the justfile include_args
#184
Conversation
printf "checking $1... " | ||
if "$1" --version 2> /dev/null ; then | ||
local dep=0 | ||
command -v "$1" 1>/dev/null || dep=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this allows checking dependencies that do not have a --version
flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One nit then lgtm
justfile
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, double whitespace
Co-authored-by: Trevor Gross <[email protected]>
Looks good, thanks for the changes! |
setup *npm-args: | ||
#!/bin/sh | ||
set -eau | ||
just _check_installed npm cargo clang clang-tidy clang-format kk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgross35 I'm surprised this kk
passed CI, I wonder if the check was skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-installed
doesn't actually require it be installed, just warn when it isn't. Maybe this should change on CI.
I actually had to adjust this in #186 and removed it there - it was always saying not found, bash syntax with a sh shebang :) I should have read the output better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have tested it myself, should not have pushed the commit
just lint
would return missing header errors for macOS making debugging tricky:Added conditional to
include_args
for handlingCPATH
tostdlib.h
:tree-sitter-just/justfile
Lines 20 to 24 in 59f661c
dependency checker now own just command:
tree-sitter-just/justfile
Lines 57 to 75 in 59f661c
Added
justfile
to.editorconfig
:tree-sitter-just/.editorconfig
Lines 41 to 43 in 59f661c