This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
refactor: RPC server with evmID (ethermint side) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
May 13, 2024
amaury1093
reviewed
May 13, 2024
amaury1093
changed the title
amaury1093
reviewed
May 14, 2024
amaury1093
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM! Small nits left
Let's wait for @lovenoble to test before merging too.
x/evm/keeper/rpc_client.go
Outdated
| // to create a new EVM instance. This is used to pass the EVM configuration | ||
| // over RPC to the SGX binary. | ||
| type PrepareTxEVMConfig struct { | ||
| type StartEVMTxEVMConfig struct { |
There was a problem hiding this comment.
Suggested change
| type StartEVMTxEVMConfig struct { | |
| type StartEVMConfig struct { |
server/start.go
Outdated
| ) | ||
|
|
||
| type IncoApp interface { | ||
| // Return evm keeper which is used in ethermint side to get evm keeper access |
There was a problem hiding this comment.
Suggested change
| // Return evm keeper which is used in ethermint side to get evm keeper access | |
| // GetEvmKeeper returns evm keeper which is used in ethermint side to get evm keeper access |
Use go-style godocs
server/start.go
Outdated
| ) | ||
|
|
||
| type IncoApp interface { |
There was a problem hiding this comment.
Suggested change
| type IncoApp interface { | |
| // incoApp is a local interface to get the EVM keeper from the Inco chain app, | |
| // without introducing any circular dependencies. | |
| type incoApp interface { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/Inco-fhevm/inco-monorepo/issues/21
To best tested with:
Description
TODO:
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)