Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve user specified join type #7

Merged
4 commits merged into from May 5, 2014
Merged

Preserve user specified join type #7

4 commits merged into from May 5, 2014

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2014

Storing the join type for a joined table in a map. Later when computing the join clause, we look up in the map to get the user specified join type.

@ghost
Copy link
Author

ghost commented May 5, 2014

@Amareshwari updated pull req. pls check

@Amareshwari
Copy link
Contributor

do we have to move the user given filter from join to where? Is it not possible to keep it in join clause itself? Somehow, i feel we should not touch user given filters.

@ghost
Copy link
Author

ghost commented May 5, 2014

This is only in case of right outer or left outer join. In that case it indicates where the filter would be executed. For ex - in case of left outer join, filter on the right table is pushed down in the join condition whereas filter on the left table is applied during scan, as its part of the where clause.

ghost pushed a commit that referenced this pull request May 5, 2014
Preserve user specified join type
@ghost ghost merged commit 02a3bb8 into InMobi:develop May 5, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant