Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON corruption and app list lost on writing settings to low storage #2089

Closed
Dahlia-desu opened this issue Jan 26, 2025 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@Dahlia-desu
Copy link

Prerequisites

Describe the bug

JSON corruption and saved app list lost on writing to low storage (0 bytes)
To Reproduce

No space left
Screenshots and Logs

2025-01-25 14:16:09.905: error: FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/nie.translator.rtranslator.json' (OS Error: No space left on device, errno = 28) [RTranslator]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.wstxda.gsl.json' (OS Error: No space left on device, errno = 28) [Google Shortcuts Launcher]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.absolute.floral.json' (OS Error: No space left on device, errno = 28) [Floral]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.wstxda.clippy.json' (OS Error: No space left on device, errno = 28) [Clippy]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.bnyro.recorder.json' (OS Error: No space left on device, errno = 28) [Record You]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.arn.scrobble.json' (OS Error: No space left on device, errno = 28) [pano-scrobbler]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.alensw.PicFolder.json' (OS Error: No space left on device, errno = 28) [Gallery]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/dev.patrickgold.florisboard.json' (OS Error: No space left on device, errno = 28) [FlorisBoard]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/com.msob7y.namida.json' (OS Error: No space left on device, errno = 28) [Namida]

FileSystemException: writeFrom failed, path = '/storage/emulated/0/Android/data/dev.imranr.obtainium.fdroid/files/app_data/app.simple.inure.json' (OS Error: No space left on device, errno = 28) [Inure]

2025-01-25 14:16:12.864: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.864: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.865: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.865: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.865: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.865: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.866: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.866: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.866: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045

2025-01-25 14:16:12.867: info: Corrupt JSON when loading App (will be ignored): 2.718281828459045
**Please complete the following information:**
 - Device: <!-- [e.g. Pixel 7] -->
 - OS: <!-- [e.g. GrapheneOS] -->
 - Obtainium Version: <!-- [e.g. 0.14.6-beta] -->

Additional context

It happened before I could make a backup, though could there be a safety net to guards against this that doesn't involve manual backups?

@Dahlia-desu Dahlia-desu added bug Something isn't working to check Issue has not been reviewed labels Jan 26, 2025
@ImranR98 ImranR98 added TODO Issue to focus on for the next release and removed to check Issue has not been reviewed labels Jan 27, 2025
ImranR98 added a commit that referenced this issue Jan 28, 2025
- Attempt to fix "double download" bug (#2073)
- Avoid JSON corruption when storage full (#2089)
- Fix error when GitLab repo is in a subgroup (#2079)
- Update screenshots in README
@ImranR98
Copy link
Owner

Should be fixed: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.40
I didn't actually test it, but the change is simple so I doubt there will be problems. If anyone runs into the same problem I'll reopen the issue.

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Jan 28, 2025
@Dahlia-desu
Copy link
Author

Tested with no issues so far! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants