Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request headers ignored for direct apk link #1688

Closed
1RandomDev opened this issue Jun 23, 2024 · 1 comment
Closed

Request headers ignored for direct apk link #1688

1RandomDev opened this issue Jun 23, 2024 · 1 comment
Labels
bug Something isn't working source-specific This bug/feature affects a specific source

Comments

@1RandomDev
Copy link

1RandomDev commented Jun 23, 2024 •
edited
Loading

I'm trying to add an app from a private repository that requires HTTP basic authentication via the direct apk link option. I entered the source URL and changed the source type to direct apk link. As request header I added Authorization: Basic <base64>. When I now click on add, none of the specified headers are sent to the server and I get an Unauthorized error at the bottom.

I tried many things with a test server and not even the default User-Agent header is added to the request. As user agent Dart/3.4 (dart:io) is used all the time and all other custom headers are completely missing.

Using Obtanium version 1.1.11
@1RandomDev 1RandomDev added bug Something isn't working to check Issue has not been reviewed labels Jun 23, 2024
ImranR98 pushed a commit that referenced this issue Jun 29, 2024
Bugfix: Missing request headers for direct APK link apps (#1688)
d391c5c
@ImranR98 ImranR98 added TODO Issue to focus on for the next release source-specific This bug/feature affects a specific source and removed to check Issue has not been reviewed labels Jun 29, 2024
@ImranR98 ImranR98 mentioned this issue Jun 29, 2024
Merged
ImranR98 added a commit that referenced this issue Jun 29, 2024
@ImranR98
Merge pull request #1696 from ImranR98/dev
cd153e7 
- Bugfix: Pull to refresh not working with few apps (#1680)
- Add third-party F-Droid repo search to main search menu (#1681)
- Added autocomplete for F-Droid repos (#1681)
- Bugfix: Missing request headers for direct APK link apps (#1688)
- Release asset download confirmation even for single choice (#1694)
- Add a less obvious touch target to highlights (#1694)
@ImranR98
Copy link
Owner

It should be fixed, we can reopen the issue if there are still problems: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.12

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working source-specific This bug/feature affects a specific source
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImranR98 @1RandomDev