703 adding growth to the plantsmodel #730
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 659-use-pyrealm-flora #730 +/- ##
======================================================
Coverage 94.86% 94.87%
======================================================
Files 73 73
Lines 4926 4935 +9
======================================================
+ Hits 4673 4682 +9
Misses 253 253 ☔ View full report in Codecov by Sentry. |
| # .. TODO: not sure what to test here? Main thing it does is change the | ||
| # dbh value, so maybe check that it has grown? |
There was a problem hiding this comment.
Ha! The .. TODO:: annotation is specific to function docstrings, so they appear nicely styled in the HTML docs. Here, plain old TODO will cover it 😄
On the question though - yes, just checking they are larger than their state before the call seems reasonable.
|
|
||
| # Check that leaf_turnover and root_turnover are correctly calculated | ||
| for cell_id in fxt_plants_model.communities.keys(): | ||
| # .. TODO: same as above, this is a bit logic-less |
There was a problem hiding this comment.
I think this is hard to avoid though, we could set up something testing for specific values but that is going to be a pain to do.
We could generate some specific numeric expectations but that does feel a bit circular.
| cohort_allometry = StemAllometry( | ||
| stem_traits=community.stem_traits, at_dbh=cohorts.dbh_values | ||
| ) |
There was a problem hiding this comment.
This is actually already populated in community.stem_allometry but at the moment there's no mechanism by which that gets updated when the DBH increases.
| # Grow the plants by increasing cohort dbh | ||
| cohorts.dbh_values += cohort_allocation.delta_dbh[0] |
There was a problem hiding this comment.
I don't think this should need that [0]? It should generate an array that maps 1-to-1 onto the cohorts?
Description
Adding functionality to
allocate_gpp, which takes the gpp and then grows the plants 😄Fixes #703
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks