-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/animal module - Energy to Mass Conversion #338
Merged
+571
−300
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
288531f
Switching to use of Data[air_temperature].
TaranRallings 3d8445b
Merge branch 'develop' into feature/animal_vr_run_integration
TaranRallings 3d176d2
Fixed small indexing bug.
TaranRallings 2f2e22c
Integrated temperature from data.
TaranRallings ed722df
Made number of individuals in a new cohort a function of reproductive…
TaranRallings b1931be
Changed cohort functions to use mass.
TaranRallings 1845b52
Reworked metabolism to follow Madingley.
TaranRallings 9f3d8c0
Collapsed mass threshold functions into single method and adding thre…
TaranRallings ae6b49e
A number of changes to convert from energy to mass with accompanying …
TaranRallings 3948374
Fixed error in dummy_plants testing.
TaranRallings 0a014a4
Merge branch 'develop' into feature/animal_module
TaranRallings 2adae11
Updated testing data instance so that it include air temperature and …
TaranRallings 1b8e8cc
Small modifications to address reviews. Exponental formats, error han…
TaranRallings f840129
Changed plant resource mass determination to only calculate for the s…
TaranRallings File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Changed plant resource mass determination to only calculate for the s…
…pecific cell.
commit f840129a47096738ba64f3f6934a98fa6e4622f8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're calculating multiple sums then only using one of them. Could you just calculate the sum you need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, and I may not be remembering correctly, this is some of @davidorme 's work from the plant module implementation. If he has no objections to the change then I am happy with it.