-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few minor bug fixes #273
Conversation
- fix intend otherwise these linear/rom systems would only be saved if no data.h5 file exist from the start - remove all files before it is written as overwriting them causes an Assertation error
This reverts commit 3bdabed.
In the previous version, less modes are extracted for free flying aircraft because number of rigid body DoFs are wrongly substracted from the total number of modes although the first modes (which are the rigid body modes) are already skipped. Thus if 30 modes are to be exported only 10 mode shapes are created.
- caused error in opening the jupyter notebook and for the tutorial not to be displayed in the readthedocs documentation
- before it creates an output file with extra columns without any values
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 67.69% 67.70%
=======================================
Files 166 166
Lines 26709 26709
=======================================
+ Hits 18081 18082 +1
+ Misses 8628 8627 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, changed look good and work for me. Thanks for removing the testing print statements, I can now rest easy :)
Hey,
Here are just a few minor bug fixes:
Enjoy your christmas holidays!