Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix polars concatenation in assembly of aeroinformation - develop #253

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

kccwing
Copy link
Collaborator

@kccwing kccwing commented Sep 28, 2023

hotfix - requesting to merge to both main and develop.
develop - together with small documentation updates
issue with using overload of + operator - if polars of the same length, the result would be a summed array rather than concatenation

rafapalacios and others added 3 commits July 15, 2023 07:16
Adding type of OS license in the text.
issue with using overload of + operator - if polars of the same length, the result would be a summed array rather than concatenation
@kccwing kccwing requested a review from sduess September 28, 2023 12:16
@kccwing kccwing changed the title fix polars concatenation in assembly of aeroinformation fix polars concatenation in assembly of aeroinformation - develop Sep 28, 2023
@kccwing kccwing added the bug label Sep 28, 2023
Copy link
Collaborator

@sduess sduess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this bug Kelvin!

@sduess sduess merged commit 23da1e0 into develop Oct 11, 2023
4 checks passed
@kccwing kccwing deleted the dev_polarbug branch October 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants