Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix striping logic for user names in oauth info_handler #102

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Jan 6, 2025

Colleague spotted this issue in another project so porting the fix over. The previous implementation would erroneously strip additional characters from the end of the username.

  • Issue:

Enter a brief description of the PR contents here

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@cc-a cc-a requested review from Steven-Eardley and J4bbi January 6, 2025 17:45
@cc-a cc-a merged commit be706b7 into develop Jan 8, 2025
2 checks passed
@cc-a cc-a deleted the rstrip-fix branch January 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants