Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run ci on push to main, exclude notebook tests on push #205

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

tomjholland
Copy link
Collaborator

This pull request includes several changes to the CI workflow configuration files, primarily focusing on improving the build and test process and removing redundant steps.

Changes to .github/workflows/ci.yml:

  • The workflow is now triggered on pushes to the main branch and on pull requests targeting the main branch. ([.github/workflows/ci.ymlL4-R6](https://github.com/ImperialCollegeLondon/PyProBE/pull/205/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL4-R6))
  • Removed the step for uploading the coverage artifact, as it is no longer needed. ([.github/workflows/ci.ymlL39-L44](https://github.com/ImperialCollegeLondon/PyProBE/pull/205/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL39-L44))
  • Added a condition to run notebook tests only on pull requests. ([.github/workflows/ci.ymlL59-R56](https://github.com/ImperialCollegeLondon/PyProBE/pull/205/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL59-R56))

Changes to .github/workflows/coverage.yml:

  • Removed the entire workflow for uploading coverage on PR merge, as it has been integrated into the main CI workflow. ([.github/workflows/coverage.ymlL1-L25](https://github.com/ImperialCollegeLondon/PyProBE/pull/205/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6L1-L25))

@tomjholland tomjholland added the infrastructure Modification or update of tooling for QA, installation, CI or deployment label Jan 12, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2c3b266). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage        ?   82.85%           
=======================================
  Files           ?       27           
  Lines           ?     2240           
  Branches        ?        0           
=======================================
  Hits            ?     1856           
  Misses          ?      384           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjholland tomjholland merged commit 99ca23d into main Jan 12, 2025
4 checks passed
@tomjholland tomjholland deleted the fix-workflows branch January 12, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Modification or update of tooling for QA, installation, CI or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants