Remove unneccessary dashboard dependencies #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pyprobe
package, focusing on simplifying the codebase, removing dependencies, and updating the testing framework. The most important changes include modifying theinfo
dictionary type, removing thedistinctipy
andordered-set
dependencies, and updating thedashboard.py
andplot.py
files to reflect these changes.Codebase simplification:
pyprobe/cell.py
: Modified theinfo
dictionary type to usedict[str, Optional[Any]]
and removed thefield_validator
for setting default values forName
andcolor
. [1] [2]pyprobe/plot.py
: Removed the default color assignment logic in theadd_line
method.pyprobe/result.py
: Updated theinfo
dictionary type to usedict[str, Optional[Any]]
. [1] [2]Dependency removal:
pyproject.toml
: Removed thedistinctipy
andordered-set
dependencies.pyprobe/cell.py
: Removed the import ofdistinctipy
.pyprobe/dashboard.py
: Removed the use ofOrderedSet
and updated the code to use a list instead. [1] [2]Feature updates:
pyprobe/dashboard.py
: Added a new select box for choosing a cell identifier as the legend label in the plot.pyprobe/dashboard.py
: Updated the plotting logic to include the selected cell identifier as the label.Testing updates:
tests/test_cell.py
: Updated tests to reflect the removal of thecolor
field and the defaultName
assignment logic.tests/test_plot.py
: Updated tests to use fixedcolor
andlabel
values instead of relying on theinfo
dictionary. [1] [2] [3] [4] [5]Documentation updates:
docs/source/user_guide/importing_data.rst
: Updated the description of theinfo
dictionary to reflect the removal of the requiredName
field.