Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccessary dashboard dependencies #198

Merged
merged 10 commits into from
Jan 8, 2025

Conversation

tomjholland
Copy link
Collaborator

This pull request includes several changes to the pyprobe package, focusing on simplifying the codebase, removing dependencies, and updating the testing framework. The most important changes include modifying the info dictionary type, removing the distinctipy and ordered-set dependencies, and updating the dashboard.py and plot.py files to reflect these changes.

Codebase simplification:

  • pyprobe/cell.py: Modified the info dictionary type to use dict[str, Optional[Any]] and removed the field_validator for setting default values for Name and color. [1] [2]
  • pyprobe/plot.py: Removed the default color assignment logic in the add_line method.
  • pyprobe/result.py: Updated the info dictionary type to use dict[str, Optional[Any]]. [1] [2]

Dependency removal:

Feature updates:

  • pyprobe/dashboard.py: Added a new select box for choosing a cell identifier as the legend label in the plot.
  • pyprobe/dashboard.py: Updated the plotting logic to include the selected cell identifier as the label.

Testing updates:

Documentation updates:

@tomjholland tomjholland added documentation Improvements or additions to documentation refactor Refactoring existing code without significantly changing functionality dependencies Pull requests that update a dependency file labels Jan 8, 2025
@tomjholland tomjholland merged commit ee6bd1d into main Jan 8, 2025
4 checks passed
@tomjholland tomjholland deleted the remove-unneccessary-dashboard-dependencies branch January 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation refactor Refactoring existing code without significantly changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant