Add logger #180
Merged
Add logger #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjholland
added
the
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces logging improvements across various modules in the
pyprobepackage. The changes primarily involve adding logging for error messages and other significant events, which will help in better tracking and debugging.Logging Enhancements:
pyprobe/__init__.py: Added a call toconfigure_logging()to set up logging when the package is initialized.pyprobe/analysis/degradation_mode_analysis.py,pyprobe/analysis/smoothing.py,pyprobe/analysis/utils.py: Imported the logging module and initialized loggers. Replaced directValueErrorraises with logging the error messages before raising the exceptions. [1] [2] [3] [4] [5] [6] [7] [8] [9]pyprobe/cell.py: Added logging for various error conditions and replacedprintstatements withlogger.infocalls. [1] [2] [3] [4] [5] [6] [7] [8]pyprobe/cyclers/basecycler.py,pyprobe/cyclers/neware.py: Added logging for error conditions in cycler data processing. [1] [2] [3] [4] [5] [6] [7] [8]pyprobe/filters.py: Introduced logging for error messages in filter operations. [1] [2] [3] [4] [5]