Fix multi file reading where columns are missing in some files #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pyprobe/cyclers/basecycler.pyfile and its corresponding test file. The changes focus on improving the handling of dataframes with missing columns and updating the concatenation method for dataframes. Additionally, a new test case has been added to verify the handling of missing columns.Changes to dataframe handling:
pyprobe/cyclers/basecycler.py: Modified the_get_dataframe_listmethod to fill missing columns with null values instead of excluding dataframes with missing columns.pyprobe/cyclers/basecycler.py: Updated theget_imported_dataframemethod to use the "diagonal" concatenation method instead of "vertical".Changes to tests:
tests/cyclers/test_basecycler.py: Added import fornumpyto support new test cases.tests/cyclers/test_basecycler.py: Added a new test casetest_with_missing_columnsto ensure dataframes with missing columns are handled correctly by filling missing values with nulls.