Patch arbin datetime bug #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjholland
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the consistency and efficiency of the cycler data processing and its corresponding tests. The most important changes include updating the date format in the maccor importer, enhancing the
datemethod to strip whitespace to fix a bug loading Arbin data, refactoring test files, and adding a helper function for test processing.Improvements to date handling:
pyprobe/cyclers/arbin.py: Changeddatetime_formatto use the month-day-year format.pyprobe/cyclers/basecycler.py: Enhanced thedatemethod to strip characters before converting to datetime.Test refactoring:
tests/cyclers/test_arbin.py: Refactored thetest_read_and_process_arbinfunction to use a new helper function and updated expected data.tests/cyclers/test_basecycler.py: Added ahelper_read_and_processfunction to streamline test processing across different cyclers.Consistency improvements in tests:
tests/cyclers/test_basytec.py: Updatedtest_read_and_process_basytecto use the new helper function.tests/cyclers/test_biologic.py: Splittest_read_and_processinto two separate tests forbiologicandbiologic_MBcyclers, using the helper function.tests/cyclers/test_maccor.py: Updatedtest_read_and_process_maccorto use the new helper function.tests/cyclers/test_neware.py: Refactoredtest_read_and_processand added a new test for processing multiple Neware files.