-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive method and PyBaMM simulation importer #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjholland
force-pushed
the
add-save-capability
branch
from
October 18, 2024 18:11
3443a70
to
f6900c8
Compare
…ways in pybamm df
… from project file
tomjholland
force-pushed
the
add-save-capability
branch
from
October 21, 2024 10:45
2d7bde7
to
98941fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pyprobe
package, focusing on adding new functionalities, improving existing features, and updating dependencies. The most important changes include the addition of new methods for handling PyBaMM solutions and archiving cells, updates to the cycle detection logic, and modifications to the procedure structure.New Functionalities:
pyprobe/cell.py
: Added methodsimport_pybamm_solution
andarchive
to handle importing PyBaMM solution objects and archiving cell objects, respectively. Also added aload_archive
function to load a cell object from an archive. [1] [2]Improvements to Existing Features:
pyprobe/filters.py
: Introduced theget_cycle_column
function to enhance cycle detection by considering cycle details from the README file if available. Updated the_cycle
function to utilize this new logic. [1] [2]pyprobe/analysis/cycling.py
: Modified thesummary
method to use the new cycle detection logic by callingget_cycle_column
.Procedure Structure Updates:
pyprobe/filters.py
: Replacedtitles
andsteps_idx
withreadme_dict
in theProcedure
class to store more comprehensive information about experiments. Updatedmodel_post_init
to initializestep_descriptions
andcycle_info
based onreadme_dict
. [1] [2]pyprobe/cell.py
: Updated theadd_procedure
method to usereadme_dict
instead of individual attributes liketitles
andsteps_idx
.Dependency Updates:
.pre-commit-config.yaml
: Addedtypes-toml
to theadditional_dependencies
list for themypy
hook.pyprobe/__init__.py
: Addedtoml
to read the version frompyproject.toml
and set__version__
.Minor Changes:
pyprobe/cyclers/basecycler.py
: Removed thecycle
property as it is now handled by the new cycle detection logic. [1] [2]pyprobe/dashboard.py
: Updated references totitles
to useexperiment_names
in thedataframe_with_selections
method. [1] [2]