Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive method and PyBaMM simulation importer #154

Merged
merged 32 commits into from
Oct 21, 2024

Conversation

tomjholland
Copy link
Collaborator

This pull request includes several changes to the pyprobe package, focusing on adding new functionalities, improving existing features, and updating dependencies. The most important changes include the addition of new methods for handling PyBaMM solutions and archiving cells, updates to the cycle detection logic, and modifications to the procedure structure.

New Functionalities:

  • pyprobe/cell.py: Added methods import_pybamm_solution and archive to handle importing PyBaMM solution objects and archiving cell objects, respectively. Also added a load_archive function to load a cell object from an archive. [1] [2]

Improvements to Existing Features:

  • pyprobe/filters.py: Introduced the get_cycle_column function to enhance cycle detection by considering cycle details from the README file if available. Updated the _cycle function to utilize this new logic. [1] [2]
  • pyprobe/analysis/cycling.py: Modified the summary method to use the new cycle detection logic by calling get_cycle_column.

Procedure Structure Updates:

  • pyprobe/filters.py: Replaced titles and steps_idx with readme_dict in the Procedure class to store more comprehensive information about experiments. Updated model_post_init to initialize step_descriptions and cycle_info based on readme_dict. [1] [2]
  • pyprobe/cell.py: Updated the add_procedure method to use readme_dict instead of individual attributes like titles and steps_idx.

Dependency Updates:

Minor Changes:

@tomjholland tomjholland added the feature Adding a new functionality, small or large label Oct 16, 2024
@tomjholland tomjholland marked this pull request as ready for review October 21, 2024 10:33
@tomjholland tomjholland merged commit f47fb14 into main Oct 21, 2024
2 checks passed
@tomjholland tomjholland deleted the add-save-capability branch October 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new functionality, small or large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant