-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional cycler parsers #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the addition of support for new cyclers, updates to the user guide documentation, and improvements to the
BaseCycler
class. The most important changes include adding support for Arbin, Maccor, and Basytec cyclers, updating the documentation to reflect these new cyclers, and refining the data validation and import processes.Support for New Cyclers:
pyprobe/cell.py
by importing their respective modules and adding them to thecycler_dict
in theprocess_cycler_file
function. [1] [2].pyprobe/cyclers/arbin.py
module to handle Arbin battery cycler data, including defining theArbin
class with appropriate column mappings.pyprobe/cyclers/maccor.py
module to handle Maccor battery cycler data. Closes Add maccor preprocessor #10pyprobe/cyclers/basytec.py
module to handle Basytec battery cycler data.Documentation Updates:
docs/source/user_guide/input_data_guidance.rst
to include information about the new cyclers and their supported file formats.Improvements to
BaseCycler
Class:BaseCycler
class inpyprobe/cyclers/basecycler.py
to ensure the validity of input data paths and column dictionaries. Closes Improve error reporting when PyProBE is unable to find required column in cycler file #140_map_columns
method to include default units and improved the handling of temperature units.pyprobe_dataframe
method to handle optional columns more gracefully and ensure proper formatting of date and capacity columns. [1] [2] [3]