Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds to the minimize optimizer used for ocv fitting #148

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

tomjholland
Copy link
Collaborator

Fix call to scipy.optimize.minimize to bound the fitted stoichometry limits between 0 and 1

@tomjholland tomjholland added the bug Something isn't working label Oct 4, 2024
@tomjholland tomjholland merged commit 5b3d72b into main Oct 4, 2024
2 checks passed
@tomjholland tomjholland deleted the BUG-fix-unbounded-minimize-OCV-fit branch October 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant