feat: use .env file to define MAG Data Visualization toolbox version

ImperialCollegeLondon · Sep 20, 2024 · 9ae4fa0 · 9ae4fa0
1 parent 92110dc
commit 9ae4fa0
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/.env b/.env
@@ -0,0 +1 @@
+MAG_DATA_VISUALIZATION_VERSION=6.0.0
diff --git a/.github/workflows/matlab.yml b/.github/workflows/matlab.yml
@@ -45,19 +45,19 @@ jobs:
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/main'
     needs: test
-    env:
-      VERSION: "6.0.0"
     steps:
       - name: Check out repository
         uses: actions/checkout@v4
       - name: Set up MATLAB
         uses: matlab-actions/[email protected]
         with:
           release: R2023b
+      - name: Load Environment Variables
+        uses: aarcangeli/[email protected]
       - name: Package toolbox
         uses: matlab-actions/[email protected]
         with:
-          tasks: package("${{ env.VERSION }}")
+          tasks: package("${{ env.MAG_DATA_VISUALIZATION_VERSION }}")
       - name: Upload toolbox
         uses: actions/[email protected]
         with:
@@ -67,6 +67,6 @@ jobs:
       - name: Create release
         uses: ncipollo/[email protected]
         with:
-          tag: v${{ env.VERSION }}
+          tag: v${{ env.MAG_DATA_VISUALIZATION_VERSION }}
           artifacts: 'artifacts/MAG Data Visualization.mltbx'
           bodyFile: 'resources/release-notes.md'
diff --git a/resources/release-notes.md b/resources/release-notes.md
@@ -18,3 +18,4 @@
 # GitHub
 
 - Run tests also with MATLAB R2024b
+- Use `.env` file to define version (also in `mag.version`)
diff --git a/src/utility/+mag/version.m b/src/utility/+mag/version.m
@@ -11,17 +11,16 @@
     if isempty(ver)
 
         location = fileparts(mfilename("fullpath"));
-        fileName = fullfile(location, "../../../.github/workflows/matlab.yml");
+        fileName = fullfile(location, "../../../.env");
 
         if isfile(fileName)
 
-            data = fileread(fileName);
-            match = regexp(data, "VERSION: ""(?<version>\d+\.\d+\.\d+)""", "once", "names");
+            env = loadenv(fileName);
 
-            if isempty(match)
-                error("Could not determine version from ""matlab.yml"" file.");
+            if env.isKey("MAG_DATA_VISUALIZATION_VERSION")
+                ver = env("MAG_DATA_VISUALIZATION_VERSION");
             else
-                ver = match.version;
+                error("Could not determine version from "".env"" file.");
             end
         else
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,3 +18,4 @@
		# GitHub

		- Run tests also with MATLAB R2024b
		- Use `.env` file to define version (also in `mag.version`)