pdfrenderer: Fix uninitialized local variables

Coverity bug reports: CID 1270405: Uninitialized scalar variable CID 1270408: Uninitialized scalar variable CID 1270409: Uninitialized scalar variable CID 1270410: Uninitialized scalar variable Those variables are set conditionally in the while loop and must keep their values in following iterations, so they must be declared outside of the loop. Signed-off-by: Stefan Weil <[email protected]>
ImageProcessing-ElectronicPublications · Nov 25, 2015 · 57402b4 · 57402b4
1 parent 1ab06fe
commit 57402b4
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/api/pdfrenderer.cpp b/api/pdfrenderer.cpp
@@ -311,6 +311,11 @@ char* TessPDFRenderer::GetPDFTextObjects(TessBaseAPI* api,
   pdf_str.add_str_double("", prec(height));
   pdf_str += " 0 0 cm /Im1 Do Q\n";
 
+  int line_x1 = 0;
+  int line_y1 = 0;
+  int line_x2 = 0;
+  int line_y2 = 0;
+
   ResultIterator *res_it = api->GetIterator();
   while (!res_it->Empty(RIL_BLOCK)) {
     if (res_it->IsAtBeginningOf(RIL_BLOCK)) {
@@ -319,7 +324,6 @@ char* TessPDFRenderer::GetPDFTextObjects(TessBaseAPI* api,
       new_block = true;          // Every block will declare its affine matrix
     }
 
-    int line_x1, line_y1, line_x2, line_y2;
     if (res_it->IsAtBeginningOf(RIL_TEXTLINE)) {
       int x1, y1, x2, y2;
       res_it->Baseline(RIL_TEXTLINE, &x1, &y1, &x2, &y2);