Fix missing 'tiff:endian' image property #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HAVE_TIFFISBIGENDIAN` macro was removed in d0b6b48, but the macro was still used for a conditional block in `tiff.c` responsible for setting the `tiff:endian` image property. The macro was never set, essentially disabling this functionality. We can safely remove the conditional compilation and assume `TIFFIsBigEndian` is always available: we require at least libtiff 4.0.0, while `TIFFIsBigEndian` was added in 3.7.0.
|
Thanks for fixing this for us. I just pushed a patch to remove the rest of the HAVE_TIFF checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix missing 'tiff:endian' image property
HAVE_TIFFISBIGENDIANmacro was removed ind0b6b48, but the macro was still used for a conditional block in
tiff.cresponsible for setting thetiff:endianimage property. The macro was never set, essentially disabling this functionality.We can safely remove the conditional compilation and assume
TIFFIsBigEndianis always available: we require at least libtiff 4.0.0, whileTIFFIsBigEndianwas added in 3.7.0.