Fix the max memory request initial value in memory.c and comparison in jpeg.c #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Avoids the error "Backing store not supported" when converting some jpeg (progressive in my case) on Windows (x86_64-w64-mingw32-gcc).
First, the initial value of max_memory_request in GetMaxMemoryRequest is inconsistent with the MagickMin return value. This was already fixed on ImageMagick 7:
I have not understood why MAGICK_SSIZE_MAX is preferred over MAGICK_SIZE_MAX.
Second, the comparison in coders/jpeg.c always returned true because neither ~0ULL nor MAGICK_SSIZE_MAX equals ~0UL on Windows when compiled with MinGW-w64, resulting in an invalid max memory size configuration in the jpeg library.