Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with -Werror #177

Merged
merged 1 commit into from
May 8, 2022

Conversation

lbartoletti
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practices as demonstrated in the repository.

Description

We have an error building 'lebiniou' on FreeBSD (and maybe other platform). 'lebiniou' uses -Werror flag and raises errors in ImageMagick6:

error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]

Removing theses const allows building 'lebiniou' (and other software using these files with -Werror flag).

FreeBSD patch: freebsd/freebsd-ports@06ba562

cc @oliv3

@urban-warrior
Copy link
Member

Can you post the output of magick -list configure here. We're trying to reproduce the issue and cannot.

@oliv3
Copy link

oliv3 commented May 8, 2022

Hi @urban-warrior, thanks for having a look !

I've setup a Gitlab CI job which reproduces the issue using:

The full job log can be found here.

Result of identify -list configure.

@urban-warrior urban-warrior merged commit 679e926 into ImageMagick:main May 8, 2022
urban-warrior pushed a commit to ImageMagick/ImageMagick that referenced this pull request May 8, 2022
@lbartoletti lbartoletti deleted the fix_build_with_Werror branch May 9, 2022 04:41
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 28, 2022
7.1.0-35 - 2022-05-16

Commits

    beta release e37bfbd
    remove special use case of Kmeans for color reduction @ ImageMagick/ImageMagick#5152 53d7d06
    fix temporary file leak 7496436
    one-off release due to "-monochrome command no longer dithers grayscale ff6dbbb

7.1.0-34 - 2022-05-15

Commits

    beta release 68a0412
    require min 3 channels for compositing 5d38476
    PDF to PBM no longer returning all white @ ImageMagick/ImageMagick#5134 8e605a2
    Removed incorrect method definition from the header file. 18ccd96
    fix build with -Werror @ ImageMagick/ImageMagick6#177 0dcacb8
    clarify usage 186578a
    eliminate compiler warnings 4fe856b
    latest autoconf/automake config 4b69c54
    cosmetic 2722c2f
    cosmetic 78a1988
    automake/autoconf update a772a53
    automake/autoconf update 9d882e4
    correct check for Magick++ compliance f4d8e6e
    automake/autoconf remove obselete macros 644472a
    build RPM tweaks 40bc17c
    tweak BZIP2 autoconf macro af5fdcd
    do not change grayscale colorspace to sRGB when compositing 05074b2
    release f2934c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants