Added TIME command that returns the current server time. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiorix
added a commit
that referenced
this pull request
Oct 21, 2014
Added TIME command that returns the current server time.
|
Thanks |
|
This is causing the build to fail on Python 2.6 without HiRedis. |
|
@lxfontes has been helping. |
|
Strange thing. Can't figure out the problem right away. So it's better to rollback now. I'll take a look later. |
|
It seems like HiRedis blocks on running the script, which is why it works on HiRedis but fails otherwise. |
|
I've created the basics of docker/fig to emulate distinct environments for testing. IMO, hiredis alone will block and cause issues now on old python and probably in the future b/c it wont return a deferred from a blocking operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TIME command that returns the current server time.