Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command execution waits to connection establishment #68

Merged
merged 1 commit into from
Jul 31, 2014

Conversation

jakm
Copy link
Contributor

@jakm jakm commented Jul 31, 2014

When lazyConnectionPool's handler is created and immediately used to execute command while TCP layer is connecting, command execution fails with ConnectionError. This change keeps connection pending until connection is established.

@fiorix
Copy link
Collaborator

fiorix commented Jul 31, 2014

You're not supposed to use lazyConnection* for clients that need immediate connectivity. The non-lazy methods are there for this purpose.
Besides this, the change does fix some other use cases.

fiorix added a commit that referenced this pull request Jul 31, 2014
command execution waits to connection establishment
@fiorix fiorix merged commit bb277f5 into IlyaSkriblovsky:master Jul 31, 2014
@jakm jakm deleted the deferred-commands branch August 1, 2014 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants