Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl option to connection #148

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

roeltm
Copy link
Contributor

@roeltm roeltm commented Mar 1, 2023

Continuation of #147.

Went throught the comments from @IlyaSkriblovsky and tested it with the attached example code.

@roeltm roeltm mentioned this pull request Mar 1, 2023
Copy link
Owner

@IlyaSkriblovsky IlyaSkriblovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work! Just a couple of stylistic comments here.

Have you tested these changes in the real life?

examples/ssl_connection.py Show resolved Hide resolved
txredisapi.py Outdated Show resolved Hide resolved
Co-authored-by: Ilya Skriblovsky <[email protected]>
@roeltm
Copy link
Contributor Author

roeltm commented Mar 2, 2023

Have you tested these changes in the real life?

yes, for others if they want to test:

  1. Generate a CA cert, and a certificate and key for the redis server (I used https://github.com/redis/redis/blob/unstable/utils/gen-test-certs.sh which generates all at once)
  2. Run the redis server with the certificate
    redis-server --tls-port 6379 --port 0 --tls-cert-file ./tests/tls/redis.crt --tls-key-file ./tests/tls/redis.key --tls-ca-cert-file ./tests/tls/ca.crt
  3. Run the ssl example script with the correct certificates

@IlyaSkriblovsky IlyaSkriblovsky merged commit e490fdb into IlyaSkriblovsky:master Mar 2, 2023
@IlyaSkriblovsky
Copy link
Owner

Thanks a lot! I will make a release on the weekend.

@roeltm
Copy link
Contributor Author

roeltm commented Mar 17, 2023

@IlyaSkriblovsky When will you be able to release this?

@IlyaSkriblovsky
Copy link
Owner

@roeltm Done it, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants