Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color to normal at end of prompt char #63

Merged
merged 2 commits into from
Jan 1, 2021

Conversation

peng1999
Copy link
Contributor

@peng1999 peng1999 commented Dec 30, 2020

Description

Set color to normal at end of prompt char

Motivation and Context

This will fix wrong coloring when pasting.

Screenshots (if appropriate)

Currently the color of commands is affected by the prompt char when pasting commands.

Screenshot_20201230_213637

Fixes #64

@peng1999 peng1999 requested a review from IlanCosman as a code owner December 30, 2020 13:39
@IlanCosman
Copy link
Owner

Thanks for opening this PR 😄 I can't seem to reproduce the problem on MacOS or an Arch VM though. Could you open a bug report for this? I'm guessing that info would be useful in diagnosing this, and it would also help to see if other people have this problem.

@peng1999
Copy link
Contributor Author

Sure. I've reported the detail information in #64.

@IlanCosman
Copy link
Owner

IlanCosman commented Dec 31, 2020

Instead of putting set_color normal at the end of prompt_char, can you do so at the end of _tide_prompt? That would ensure that every item doesn't have this problem.

@peng1999
Copy link
Contributor Author

peng1999 commented Jan 1, 2021

The set_color normal is in _tide_prompt now.

@IlanCosman IlanCosman merged commit fb22b3b into IlanCosman:main Jan 1, 2021
@IlanCosman
Copy link
Owner

Thanks a bunch 😄

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The prompt char affects fish's syntax highlighting
2 participants