Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prompt char affects fish's syntax highlighting #64

Closed
peng1999 opened this issue Dec 31, 2020 · 4 comments · Fixed by #63
Closed

The prompt char affects fish's syntax highlighting #64

peng1999 opened this issue Dec 31, 2020 · 4 comments · Fixed by #63
Labels
🐛 bug Something isn't working

Comments

@peng1999
Copy link
Contributor

peng1999 commented Dec 31, 2020

Describe the bug

Steps to reproduce

  1. copy an arbitrary command text.
  2. open a terminal and paste the text, usually using Shift+Ins or Ctrl+Shift+V.
  3. See error

Expected behavior

Expected: (the style of echo should be bold while)
Screenshot_20201231_101408

Actual: (the color of echo becomes the same as the prompt char)
Screenshot_20201230_213637

Environment (please complete the following information)

  • Operating System: Manjaro Linux
  • Output of tide bug-report:
tide bug-report
fish, version 3.1.2
tide, version 3.0.0
alacritty

Additional context

Tested in alacritty, konsole, tmux in alacritty, and tmux in konsole. The described behaviour is consistent.

@peng1999 peng1999 added the 🐛 bug Something isn't working label Dec 31, 2020
@IlanCosman
Copy link
Owner

Could you provide the output of echo $fish_color_command?

@peng1999
Copy link
Contributor Author

It’s —bold:

echo $fish_color_command 
--bold

@IlanCosman
Copy link
Owner

So the problem here is that your fish_color_command isn't actually a color, so Fish just lets Tide's color continue. For example, if you changed your fish_color_command to --bold white instead of allowing the white to be assumed, this bug wouldn't appear. I suppose Tide ought to be self contained here, but this is a very niche reason. I'll have a change to request on the PR, thanks for reporting this 😄

@kidonng
Copy link
Contributor

kidonng commented Jun 4, 2021

Oops, wrong issue to comment. 😅 Sorry for the disturb!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants