Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdd timeline sample #21

Open
wants to merge 9 commits into
base: 24.1.x
Choose a base branch
from
Open

Mdd timeline sample #21

wants to merge 9 commits into from

Conversation

mddifilippo89
Copy link
Contributor

@mddifilippo89 mddifilippo89 commented Apr 4, 2022

TimeXAxis sample doesn't work.
xMemeberPath on callout layer breaks the annotation.

@mddifilippo89 mddifilippo89 added the status: 🛠️ in-development things that are not finished label Apr 4, 2022
**Does Not Work**
TimeXAxis causes series not to render.
CalloutLayer's xMemberPath causes annotation not to render.
@mddifilippo89 mddifilippo89 added the bug: in-sample sample isn't working label Apr 4, 2022
@mddifilippo89
Copy link
Contributor Author

mddifilippo89 commented Apr 5, 2022

Exporting the sample throws exception. Line 724 WPFSurfaceHost.cs

image

Copy link
Collaborator

@HUSSAR-mtrela HUSSAR-mtrela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix issues listed in comments below.

{"Date": "2017, 3, 19", "Year": "19 March, 2018", "Value": 5, "Details": "The EU and the UK agree on a transition phase"},
{"Date": "2018, 11, 25", "Year": "25 November, 2018", "Value": 5, "Details": "Draft withdrawl deal agreed"},
{"Date": "2019, 10, 29", "Year": "29 October, 2019", "Value": 5, "Details": "EU heads of state and government approve postponing the Brexit date"},
{"Date": "2020, 12, 31", "Year": "31 December, 2020", "Value": 5, "Details": "Transition period ends"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Year data column should display months in short format, e.g. NOV for November

"calloutOutline": "#EC0D00",
"calloutBackground": "transparent",
"isCalloutOffsettingEnabled": false,
"textStyle": "font-size: 25px",
Copy link
Collaborator

@HUSSAR-mtrela HUSSAR-mtrela Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using such large font size will make callouts overlap when the chart is small in docs
please change it to smaller font, e.g. 0.8rem

"series": [
{
"type": "LineSeries",
"name": "LineSeries1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing title setting

@HUSSAR-mtrela HUSSAR-mtrela added status: 📕 blocked things blocked by missing content in samples and removed bug: in-sample sample isn't working status: 🛠️ in-development things that are not finished labels Nov 3, 2022
@HUSSAR-mtrela HUSSAR-mtrela changed the base branch from master to vnext March 16, 2023 15:02
@HUSSAR-mtrela HUSSAR-mtrela added the status: 🛠️ in-development things that are not finished label Jul 6, 2023
@HUSSAR-mtrela HUSSAR-mtrela changed the base branch from vnext to 23.1.x August 24, 2023 15:49
@HUSSAR-mtrela HUSSAR-mtrela changed the base branch from 23.1.x to 24.1.x July 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: 📕 blocked things blocked by missing content in samples status: 🛠️ in-development things that are not finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants