Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(input): add hidden overflow to prefix and sufix #359

Merged
merged 4 commits into from
May 10, 2022
Merged

style(input): add hidden overflow to prefix and sufix #359

merged 4 commits into from
May 10, 2022

Conversation

didimmova
Copy link
Contributor

Closes #353

simeonoff
simeonoff reviewed May 10, 2022
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make this change only in the bootstrap theme? Doesn't the issue appear in all themes? If that's the case, then we may need to make the change in the base theme.

@didimmova didimmova requested a review from simeonoff May 10, 2022 13:30
@simeonoff simeonoff self-requested a review May 10, 2022 13:48
@simeonoff simeonoff merged commit 2772658 into master May 10, 2022
@simeonoff simeonoff deleted the didimmova/input-layout branch May 10, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees
No one assigned
Labels
input themes ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input prefix/suffix containers expand outside the main box with larger elements
2 participants
@didimmova @simeonoff