fix test errors #1379
Open
fix test errors #1379
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,4 +32,4 @@ jobs: | |||
| - run: npm i # replace with 'npm ci' after committing lock file from first install | |||
| - run: npm run lint | |||
| - run: npm run build | |||
| - run: npm run test -- --watch=false --browsers ChromeHeadless | |||
| - run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless | |||
There was a problem hiding this comment.
Not particularly sure if we should add the flag here as this will also add it for all generated project. This may not be ideal if its sole purpose is to allow the automation on generated apps to run properly. It does not seem to be needed when publishing to GitHub and running the CI - link
There was a problem hiding this comment.
I removed it form the yml files and added it to the package.json files
added 6 commits
February 24, 2025 16:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors when running ng/npm run test command for angular, react and wc