Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing global replacement. #1339

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Removing global replacement. #1339

merged 1 commit into from
Nov 15, 2024

Conversation

dkalinovInfra
Copy link
Contributor

Removing 'define' from vite.config.

This configuration tells Vite to replace all instances of global with window in the code before building the project. It's essentially a straightforward text replacement or string substitution mechanism. Any occurrence of the word global in the code will be replaced with window, regardless of the context. This means if the project have variables, function names, or anything else that contains global as a substring (like globalView, isGlobalEnabled), these will also be replaced.

@coveralls
Copy link

Coverage Status

coverage: 70.31%. remained the same
when pulling c1f1847 on dkalinov/globalFix
into 6de8673 on master.

@wnvko wnvko merged commit 0f26967 into master Nov 15, 2024
3 checks passed
@wnvko wnvko deleted the dkalinov/globalFix branch November 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants