Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lite-server package and quickstart #1334

Merged
merged 17 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"/node_modules/**/*",
"/coverage/**/*",
"/output/**/*",
"/packages/cli/quickstart/**/*",
"/packages/cli/templates/**/*",
"**/files/**/*"
],
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ packages/core/config/Config.schema.json
!packages/cli/templates/jquery/**/files/**/*
!packages/cli/templates/angular/**/files/**/*
!packages/cli/templates/react/**/files/**/*
!packages/cli/templates/quickstart/**/*

# Misc
npm-debug.log*
Expand Down
3 changes: 1 addition & 2 deletions .vscode/cSpell.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
"language": "en",
// words - list of words to be always considered correct
"words": [
"infragistics",
"quickstart"
"infragistics"
],
// flagWords - list of words to be always considered incorrect
// This is useful for offensive words and common spelling errors.
Expand Down
42 changes: 0 additions & 42 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -175,48 +175,6 @@
"upgrade-packages",
]
},
{
"type": "node",
"request": "launch",
"name": "Launch Quickstart jQuery",
"cwd": "${workspaceRoot}/output",
"program": "${workspaceRoot}/packages/cli/bin/execute.js",
"console": "externalTerminal",
"preLaunchTask": "build",
"outFiles": ["${workspaceFolder}/**/*.js"],
"args": [
"quickstart",
"--framework=jquery"
]
},
{
"type": "node",
"request": "launch",
"name": "Launch Quickstart React",
"cwd": "${workspaceRoot}/output",
"program": "${workspaceRoot}/packages/cli/bin/execute.js",
"console": "externalTerminal",
"preLaunchTask": "build",
"outFiles": ["${workspaceFolder}/**/*.js"],
"args": [
"quickstart",
"--framework=react"
]
},
{
"type": "node",
"request": "launch",
"name": "Launch Quickstart Angular",
"cwd": "${workspaceRoot}/output",
"program": "${workspaceRoot}/packages/cli/bin/execute.js",
"console": "externalTerminal",
"preLaunchTask": "build",
"outFiles": ["${workspaceFolder}/**/*.js"],
"args": [
"quickstart",
"--framework=angular"
]
},
{
"type": "node",
"request": "launch",
Expand Down
3 changes: 1 addition & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
},
"tslint.exclude": [
"**/files/**/*.ts",
"./output/**/*.ts",
"./quickstart/**/*.ts"
"./output/**/*.ts"
]
}
2 changes: 0 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,6 @@ You can install the Ignite UI for Angular Schematics globally and use them to cr
- **templates, igx-ts, ig-ts**: Update Angular tests - references, configurations, and templates
- **templates, igx-ts**: Update angular charts packages to 8.2.12 #644
- **templates, js**: Update ignite-ui to v19.2 #625
- **templates, js**: Update jquery quickstart #625


# [4.3.6](https://github.com/IgniteUI/igniteui-cli/compare/v4.3.5...v4.3.6) (2020-01-29)
Expand Down Expand Up @@ -2207,7 +2206,6 @@ A brand new project template type for Ignite UI for Angular with built-in authen
* update Ignite UI for Angular to 6.0.0 and project to Angular 6 ([f878c37](https://github.com/IgniteUI/igniteui-cli/commit/f878c37))
* update Ignite UI Angular wrappers project to Angular 6 [7868d8f](https://github.com/IgniteUI/igniteui-cli/commit/7868d8f)
* update Ignite UI for JavaScript to 18.1 in jQuery, React and Angular wrappers projects ([16afac22](https://github.com/IgniteUI/igniteui-cli/commit/16afac22), [1c91a4d](https://github.com/IgniteUI/igniteui-cli/commit/1c91a4d), [65b8190](https://github.com/IgniteUI/igniteui-cli/commit/65b8190))
* update quickstart projects ([84d8fc9](https://github.com/IgniteUI/igniteui-cli/commit/84d8fc9))


<a name="1.3.0"></a>
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ See the [Contribution guide](https://github.com/IgniteUI/igniteui-cli/blob/maste
3. To build the packages, run `yarn build` in the project `root`.
4. Open in Visual Studio Code

There is a predefined launch.config file for VS Code in the root folder, so you can use VS Code View/Debug window and choose one of the predefined actions. These include launching the step by step guide, quickstart project, create new project for a particular framework or add components.
There is a predefined launch.config file for VS Code in the root folder, so you can use VS Code View/Debug window and choose one of the predefined actions. These include launching the step by step guide, create new project for a particular framework or add components.

5. Hit Start Debugging/F5

Expand Down
13 changes: 1 addition & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"exclude": [
"**/*.d.ts",
"output/",
"packages/cli/templates/quickstart/",
"packages/cli/templates/**/files/",
"packages/igx-templates/"
],
Expand Down Expand Up @@ -77,23 +76,13 @@
"jasmine-spec-reporter": "^7.0.0",
"lerna": "^8.1.9",
"lerna-changelog": "^2.2.0",
"lite-server": "^2.6.1",
"nyc": "^17.0.0",
"resolve": "^1.22.8",
"source-map-support": "^0.5.21",
"ts-node": "^10.9.2",
"tslint": "^5.11.0",
"typescript": "~5.6.2",
"typescript-json-schema": "^0.65.1",
"parse-url": "^8.1.0",
"braces": "^3.0.3",
"highlight.js": "^10.4.1",
"mem": "^4.0.0",
"tar": "^6.2.1",
"micromatch": "^4.0.8",
"trim-newlines": "^3.0.1",
"parse-path": "^5.0.0",
"http-cache-semantics": "^4.1.1"
"typescript-json-schema": "^0.65.1"
},
"workspaces": [
"packages/*"
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ See the [Contribution guide](https://github.com/IgniteUI/igniteui-cli/blob/maste
2. Install dependencies with `npm install`
3. Open in Visual Studio Code

There is a predefined launch.config file for VS Code in the root folder, so you can use VS Code View/Debug window and choose one of the predefined actions. These include launching the step by step guide, quickstart project, create new project for a particular framework or add components.
There is a predefined launch.config file for VS Code in the root folder, so you can use VS Code View/Debug window and choose one of the predefined actions. These include launching the step by step guide, create new project for a particular framework or add components.

4. Hit Start Debugging/F5

Expand Down
8 changes: 0 additions & 8 deletions packages/cli/lib/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import {
generate,
list,
newCommand,
quickstart,
QUICKSTART_COMMAND_NAME,
start,
test,
upgrade,
Expand Down Expand Up @@ -46,7 +44,6 @@ export async function run(args = null) {
await yargsModule
.scriptName("") // prevent the addition of the name of the executing script in the usage output
.usage("") // do not show any usage instructions before the commands list
.command(quickstart)
.command(newCommand)
.command(add)
.command(build)
Expand Down Expand Up @@ -106,11 +103,6 @@ export async function run(args = null) {
logHelp();
}

if (command === QUICKSTART_COMMAND_NAME && !helpRequest) {
Util.log("quickstart Created");
return;
}

// since we are providing a custom callback to `yargsModule.parseAsync`, we need to handle the output as well
// ref - https://yargs.js.org/docs/#api-reference-parseargs-context-parsecallback
if (output) {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/commands/add.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const command: AddCommandType = {
}
const config = ProjectConfig.getConfig();
if (config.project.isShowcase) {
Util.error("Showcases and quickstart projects don't support the add command", "red");
Util.error("Showcases projects don't support the add command", "red");
return;
}
const framework = command.templateManager.getFrameworkById(config.project.framework);
Expand Down
1 change: 0 additions & 1 deletion packages/cli/lib/commands/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export { default as doc } from "./doc";
export { default as generate } from "./generate";
export { default as list } from "./list";
export { default as newCommand } from "./new";
export { default as quickstart } from "./quickstart";
export { default as start } from "./start";
export { default as test } from "./test";
export { default as upgrade } from "./upgrade";
Expand Down
91 changes: 0 additions & 91 deletions packages/cli/lib/commands/quickstart.ts

This file was deleted.

2 changes: 0 additions & 2 deletions packages/cli/lib/commands/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { AddTemplateArgs, Template } from "@igniteui/cli-core";

export const ADD_COMMAND_NAME = "add";
export const NEW_COMMAND_NAME = "new";
export const QUICKSTART_COMMAND_NAME = "quickstart";
export const BUILD_COMMAND_NAME = "build";
export const START_COMMAND_NAME = "start";
export const GENERATE_COMMAND_NAME = "generate";
Expand All @@ -17,7 +16,6 @@ export const UPGRADE_COMMAND_NAME = "upgrade-packages";
export const ALL_COMMANDS = new Set([
ADD_COMMAND_NAME,
NEW_COMMAND_NAME,
QUICKSTART_COMMAND_NAME,
BUILD_COMMAND_NAME,
START_COMMAND_NAME,
GENERATE_COMMAND_NAME,
Expand Down
3 changes: 0 additions & 3 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"templates/**/*.js",
"templates/**/files/**/*",
"templates/**/generate/**/*",
"templates/quickstart/**/*",
"templates/**/*.json",
"migrations/**/*.d.ts",
"migrations/**/*.js",
Expand All @@ -63,7 +62,6 @@
"exclude": [
"**/*.d.ts",
"output/",
"templates/quickstart/",
"templates/**/files/"
],
"reporter": [
Expand Down Expand Up @@ -100,7 +98,6 @@
"coveralls-next": "^4.2.1",
"jasmine": "^5.3.0",
"jasmine-spec-reporter": "^7.0.0",
"lite-server": "^2.6.1",
"nyc": "^17.0.0",
"rxjs": "^7.8.1",
"source-map-support": "^0.5.21",
Expand Down
20 changes: 0 additions & 20 deletions packages/cli/templates/quickstart/angular/.editorconfig

This file was deleted.

21 changes: 0 additions & 21 deletions packages/cli/templates/quickstart/angular/LICENSE

This file was deleted.

Loading
Loading