Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typedoc theme): allow shell localization typedoc theme #2704

Merged
merged 7 commits into from
Oct 12, 2018

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Oct 5, 2018

Closes #2703

waiting the following pull requests:
typedoc-plugin-localization: 10
typedoc-plugin-localization: 11

@Aleksandyr Aleksandyr changed the title feat(typedoc theme): allow shell localization typedoc theme [DO NOT MERGE] feat(typedoc theme): allow shell localization typedoc theme Oct 5, 2018
@zdrawku zdrawku changed the title [DO NOT MERGE] feat(typedoc theme): allow shell localization typedoc theme feat(typedoc theme): allow shell localization typedoc theme Oct 9, 2018
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 9, 2018
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • shell-strings file should be provided for testing purposes (add it to the root of the project)
    image

  • npm run build:lib

  • npm run build:docs

  • npx typedoc ./projects/igniteui-angular/src/ --localize jp --templateStrings ./shell-strings.json

  • open dist/
    Tested with versions:
    image

Issue is reported for possible enhancements

@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 12, 2018
@zdrawku zdrawku merged commit 8e6165e into master Oct 12, 2018
@zdrawku zdrawku deleted the theme-shell-local-updates branch October 12, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
material-theme typedoc version: 6.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants