Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure hours stay clamped within 0-23 when interacting with AM/PM - 18.2.x #15369

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Ensure hours stay clamped within 0-23 when interacting with AM/PM - 18.2.x #15369

merged 4 commits into from
Feb 17, 2025

Conversation

jackofdiamond5
Copy link
Member

Closes #15158

Description in PR #15367

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5
test(time-picker): ensure view does not reset when clicking am/pm
0365984 
(cherry picked from commit ec3b3e2)
(cherry picked from commit 9ff50ad)
@jackofdiamond5
fix(time-picker): clamp hrs between 0-23 during interactions
52d1923 
(cherry picked from commit e0dd4c4)
(cherry picked from commit 07ef9d2)
@jackofdiamond5
test(time-picker): add more scenarios & remove unused global const
902fad9 
(cherry picked from commit 9f2c4bc)
(cherry picked from commit fe1a1f0)
@Lipata Lipata added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 17, 2025
@Lipata Lipata merged commit 191013c into 18.2.x Feb 17, 2025
5 checks passed
@Lipata Lipata deleted the bpenkov/tp-am-pm-interactions-18.2.x branch February 17, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

Assignees
No one assigned
Labels
🕐 time-picker version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackofdiamond5 @Lipata