Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drop-down): ensure id attribute is set correctly when using bracket syntax - 18.1.x #14584

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix(drop-down): ensure id attribute is set correctly when using bracket syntax - 18.1.x #14584

merged 2 commits into from
Jul 30, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14579

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov georgianastasov added ❌ status: awaiting-test PRs awaiting manual verification dropdown select Select component version: 18.1.x labels Jul 25, 2024
@georgianastasov georgianastasov linked an issue Jul 25, 2024 that may be closed by this pull request
Missing host attr.id in igx-select when using id with bracket-syntax #14579
Closed
@Lipata
Copy link
Member

Lipata commented Jul 26, 2024

@georgianastasov please, while testing, do a test with several drop downs, and selects and verify that all ids are properly incremented.

@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 29, 2024
@kacheshmarova kacheshmarova merged commit bab8ff8 into 18.1.x Jul 30, 2024
4 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/fix-14579-18.1.x branch July 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@Zneeky Zneeky Awaiting requested review from Zneeky

Assignees
No one assigned
Labels
dropdown select Select component version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing host attr.id in igx-select when using id with bracket-syntax
4 participants
@georgianastasov @Lipata @kacheshmarova @Zneeky