Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-highlight): implement disposal #13927

Merged
merged 4 commits into from
Feb 20, 2024
Merged

feat(text-highlight): implement disposal #13927

merged 4 commits into from
Feb 20, 2024

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Feb 19, 2024

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@gedinakova gedinakova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 20, 2024
gedinakova
gedinakova previously approved these changes Feb 20, 2024
View reviewed changes
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Feb 20, 2024
@damyanpetev damyanpetev merged commit 5472d6d into master Feb 20, 2024
5 of 6 checks passed
@damyanpetev damyanpetev deleted the text-highlight-dispose branch February 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@gedinakova gedinakova gedinakova left review comments

Assignees

@gedinakova gedinakova

Labels
squash-merge Merge PR with "Squash and Merge" option text-highlight version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdinev @damyanpetev @gedinakova