Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(text-highlight): abstracting service from directive #13915

Merged
merged 9 commits into from
Feb 16, 2024
Merged

refactor(text-highlight): abstracting service from directive #13915

merged 9 commits into from
Feb 16, 2024

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Feb 15, 2024 •
edited
Loading

Related #13562

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@kdinev kdinev mentioned this pull request Feb 15, 2024
Closed
11 tasks
@kdinev kdinev assigned gedinakova and unassigned damyanpetev Feb 15, 2024
gedinakova
gedinakova previously approved these changes Feb 15, 2024
View reviewed changes
@gedinakova gedinakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 15, 2024
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 15, 2024
@damyanpetev
Copy link
Member

Can confirm highlight now tree-shakes correctly when not used (chip + button group bundle):
image
image

damyanpetev
damyanpetev approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the docs & samples, since the static methods are used there, otherwise LGTM

@kdinev
Copy link
Member Author

kdinev commented Feb 16, 2024

We should update the docs & samples, since the static methods are used there, otherwise LGTM

IgniteUI/igniteui-docfx#5717

@kdinev kdinev merged commit 26d3cd6 into master Feb 16, 2024
5 of 6 checks passed
@kdinev kdinev deleted the text-highlight-service branch February 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@gedinakova gedinakova gedinakova left review comments

Assignees

@gedinakova gedinakova

Labels
refactoring text-highlight version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdinev @damyanpetev @gedinakova