-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(h-grid): provide injector to simplify child toolbar template setup #13907
Conversation
@damyanpetev LGTM. |
I think the grid reference can still be useful for other use cases (perhaps custom buttons that call some grid API), so it could be left exposed. Wondering if we should expose it the same way for the paginator, but I digress. |
The directive that holds the grid context can stay. I'm talking about this I don't think the toolbar can be used outside of the grid. Since something like this:
Thrown an injection error. And judging by the api docs around the prop, it was used for the hierarchical grid children only, so maybe it can be removed now. |
This allows the definition of child grid toolbar templates without the explicit need to get the grid ref and assign it to the toolbar.
So from:
to
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)