Make HammerJs optional. #13905
Merged
Make HammerJs optional. #13905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayaKirova
added
❌ status: awaiting-test
…ers in no longer a required dependency.
IMinchev64
added
✅ status: verified
|
@MayaKirova Please resolve the |
kdinev
reviewed
Feb 16, 2024
damyanpetev
reviewed
Feb 16, 2024
| @@ -21,8 +21,7 @@ | |||
| "main": "./src/main.ts", | |||
| "index": "src/index.html", | |||
| "polyfills": [ | |||
| "zone.js", | |||
| "hammerjs" | |||
There was a problem hiding this comment.
Okay if we keep it installed, we could still use it for testing purposes in the dev demos, no?
damyanpetev
requested changes
Feb 16, 2024
MayaKirova
removed
the
✅ status: verified
damyanpetev
approved these changes
Feb 19, 2024
kdinev
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)