Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxGridState: does not restore collapsible column groups #13895

Merged
merged 19 commits into from
Feb 20, 2024
Merged

IgxGridState: does not restore collapsible column groups #13895

merged 19 commits into from
Feb 20, 2024

Conversation

valeriatoneva
Copy link
Collaborator

@valeriatoneva valeriatoneva commented Feb 12, 2024 •
edited
Loading

Closes #13848

This PR addresses the issue where collapse/expand is not functioning correctly in an IgxGrid with column groups.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@valeriatoneva valeriatoneva self-assigned this Feb 12, 2024
@valeriatoneva valeriatoneva added the 🛠️ status: in-development Issues and PRs with active development on them label Feb 12, 2024
@valeriatoneva valeriatoneva changed the title fix(column-groups): add conditional logic for collapsible and expanded IgxGridState: does not restore collapsible column groups Feb 13, 2024
@valeriatoneva valeriatoneva added ❌ status: awaiting-test PRs awaiting manual verification grid: collapsible-column-groups grid: multi-column-headers and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 14, 2024
@hanastasov hanastasov requested review from dobromirts and removed request for hanastasov February 15, 2024 07:21
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 15, 2024
@hanastasov hanastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 15, 2024
@hanastasov hanastasov assigned hanastasov and unassigned dobromirts Feb 15, 2024
@hanastasov hanastasov requested review from hanastasov and removed request for dobromirts February 15, 2024 14:13
hanastasov
hanastasov previously approved these changes Feb 15, 2024
View reviewed changes
@hanastasov
Copy link
Contributor

Waiting for tests to be added.

@hanastasov hanastasov self-requested a review February 15, 2024 14:14
hanastasov
hanastasov reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, let's commit the tests and then is ready for merge.

hanastasov
hanastasov requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you know how to write the test through the state directive, so waiting for those changes.

hanastasov
hanastasov requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @valeriatoneva ! Make sure you address the requested changes and then the PR is good to go.

projects/igniteui-angular/src/lib/grids/state.directive.spec.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/state.directive.spec.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/state.directive.spec.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/state.directive.spec.ts Outdated Show resolved Hide resolved
src/app/grid-state/grid-state.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/columns/column.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/columns/column.component.ts Outdated Show resolved Hide resolved
@hanastasov hanastasov self-requested a review February 20, 2024 07:27
@hanastasov hanastasov merged commit 8ba4a32 into master Feb 20, 2024
6 checks passed
@hanastasov hanastasov deleted the valeriatoneva/fix-collapsible-column-groups-state branch February 20, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

Assignees

@hanastasov hanastasov

Labels
grid: collapsible-column-groups grid: multi-column-headers ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgxGridState: does not restore collapsible column groups
3 participants
@valeriatoneva @hanastasov @dobromirts