-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): Correct shift-click selection in grouped IgxGrid #13757 #13785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanastasov
reviewed
Jan 9, 2024
projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
Outdated
Show resolved
Hide resolved
…into valeriatoneva/fix-13757-master
Please remove the changes from package, package-lock files, the forgotten console.logs, and formattings that appear in the file. Also, add unit test covering the scenario reported. The unit test should fail without the fix and pass with the fix. After all of this you can open PR against 16.1.x, 17.0.x branches as well. |
ddincheva
approved these changes
Jan 23, 2024
ddincheva
added
💥 status: in-test
PRs currently being tested
✅ status: verified
Applies to PRs that have passed manual verification
and removed
💥 status: in-test
PRs currently being tested
labels
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13757
This PR addresses the issue where shift-click was not functioning correctly in an IgxGrid with grouped rows. The selection logic has been updated to properly handle multi-level group comparisons, ensuring that the shift-click selection is consistent and intuitive in grouped grids.
Additional information:
Checklist: