Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): Correct shift-click selection in grouped IgxGrid #13757 #13785

Merged
merged 19 commits into from
Jan 23, 2024

Conversation

valeriatoneva
Copy link
Collaborator

Closes #13757

This PR addresses the issue where shift-click was not functioning correctly in an IgxGrid with grouped rows. The selection logic has been updated to properly handle multi-level group comparisons, ensuring that the shift-click selection is consistent and intuitive in grouped grids.

Additional information:

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@valeriatoneva valeriatoneva self-assigned this Jan 8, 2024
@hanastasov hanastasov added the ❌ status: awaiting-test PRs awaiting manual verification label Jan 15, 2024
@hanastasov
Copy link
Contributor

hanastasov commented Jan 16, 2024

Please remove the changes from package, package-lock files, the forgotten console.logs, and formattings that appear in the file. Also, add unit test covering the scenario reported. The unit test should fail without the fix and pass with the fix.

After all of this you can open PR against 16.1.x, 17.0.x branches as well.

@ddincheva ddincheva removed the ❌ status: awaiting-test PRs awaiting manual verification label Jan 23, 2024
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 23, 2024
@hanastasov hanastasov merged commit 84be07c into master Jan 23, 2024
6 checks passed
@hanastasov hanastasov deleted the valeriatoneva/fix-13757-master branch January 23, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxGrid: Shift click not working correctly when grouping is activated
3 participants