Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): implementing rowClick event #13763

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Conversation

ChronosSF
Copy link
Member

@ChronosSF ChronosSF commented Dec 15, 2023

Closes #13755

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev
Copy link
Member

skrustev commented Jan 3, 2024

@ChronosSF It seems like the summary row is also a separate implementation when enabled with group by, I assume it should also trigger click event?

PS: Nvm it seems like you cannot click on the whole summary row.

@IMinchev64 IMinchev64 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 3, 2024
@ChronosSF ChronosSF merged commit ca99582 into master Jan 8, 2024
5 checks passed
@ChronosSF ChronosSF deleted the sstoychev/row-click branch January 8, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
4 participants